Skip to content

Conversation

@Cra3z
Copy link
Contributor

@Cra3z Cra3z commented Feb 12, 2026

This PR will implement P3815 - scope_association, which represents a possible association between a sender and an async scope.

@ClausKlein
Copy link
Collaborator

Please do pip install pre-commit and use it with: pre-commit run --all

We have to modes: with and w/o CXX_MODULES!

-- Detecting CXX compile features - done
-- BEMAN_USE_STD_MODULE=OFF
-- BEMAN_USE_MODULES=ON
-- CMAKE_CXX_SCAN_FOR_MODULES=ON

Copy link
Collaborator

@ClausKlein ClausKlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please respect the existing ifdefs

Comment on lines 8 to 10
#ifdef BEMAN_HAS_MODULES
import beman.execution;
#else
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK: This is needed!

Comment on lines 9 to 11
#ifdef BEMAN_HAS_MODULES
import beman.execution;
#else
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK: This is needed!

Comment on lines 9 to 11
#ifdef BEMAN_HAS_MODULES
import beman.execution;
#else
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK: This is needed!

@coveralls
Copy link

Coverage Status

coverage: 93.991% (+0.2%) from 93.745%
when pulling 8fa8782 on Cra3z:main
into f3dcb8f on bemanproject:main.

@Cra3z Cra3z requested a review from ClausKlein February 13, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants