Return process object asynch#98
Open
mariadb-JeffBachtel wants to merge 3 commits intobeelit94:developfrom
Open
Return process object asynch#98mariadb-JeffBachtel wants to merge 3 commits intobeelit94:developfrom
mariadb-JeffBachtel wants to merge 3 commits intobeelit94:developfrom
Conversation
Collaborator
|
@aubustou what do you think about this? |
|
Some news about this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the old
python-terraformcode, the Popen object was returned insynchronous=Truemode. My team needs this functionality to be able to tee the terraform output to stdout/stderr at the same time we capture the output and use it for internal processing.I understand it's not ideal to override the returned Tuple in this way, but this PR does document the possible return with type annotations.
If this PR isn't acceptable, is there any other path to getting the process object?