Conversation
* Use a more recent rules_kotlin version (1.9.5) * Use a more recent compose compiler version (1.9.22) * Add android_ndk_repository dependency Fixes bazelbuild/bazel#20970
|
All of the failures in this PR were caused by missing native |
|
those failures are blocking other PRs like #453 - @meteorcloudy do you know if anyone is buildcop for this repo? |
|
Unfortunately, there is no buildcop for this repo, we basically try to identify the owner for specific example code. However, @sgowroji is helping reporting breakages: #454 This looks like to be caused by some changes at Bazel HEAD. Like bazelbuild/bazel@947c72d, @ahumesky can you help fix the example in this repo? |
|
The root cause of the problem is that we deleted the native aar_import() rule in Bazel, but rules_jvm_external instantiates a native aar_import rule in all previous versions. In the latest rules_jvm_external release, the problem is fixed after adding 2 new attributes to the maven.install() call that basically tell rules_jvm_external to use the rules_android starlark version of aar_import. To completely fix, we'll have to update the rules_jvm_external version of every project in bazelbuild/examples, and then add those extra attributes. Or, we'll have to update rules_jvm_external to use the Starlark aar_import by default. |
|
We're working on updating the downstream repos |
|
Is there a good reason this repo should use Bazel @Head? As an example for end-users it would be more appropriate to use the latest LTS as the primary CI. |
|
The repo here uses last_green for the firebase example ( Line 5 in 4679b39 is also failing so we'll need to fix this for bazel@HEAD anyway |
|
This was switched to last_green to update platforms: 5e37d3c I wonder if whatever changes were needed in bazel near head are in 7.x by now |
| kt_register_toolchains() | ||
|
|
||
| ## NDK | ||
| http_archive( |
There was a problem hiding this comment.
curious, why do we need the NDK dependency?
Fixes bazelbuild/bazel#20970