Minor refactor for mingw, data type tweaks, and warning removal.#5
Open
SolomonSklash wants to merge 6 commits intobats3c:masterfrom
Open
Minor refactor for mingw, data type tweaks, and warning removal.#5SolomonSklash wants to merge 6 commits intobats3c:masterfrom
SolomonSklash wants to merge 6 commits intobats3c:masterfrom
Conversation
…n definitions to remove warnings.
hypervis0r
approved these changes
Aug 7, 2021
Contributor
hypervis0r
left a comment
hypervis0r
left a comment
There was a problem hiding this comment.
yeah this unicode string bug needs to be fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a few minor tweaks to better support mingw and to reduce compiler warnings:
no previous declaration forwarnings.darkmodule.hwas created to contain the_DARKMODULEstruct definition. This is so thatdarkloadlibrary.hcan include each of the other headers with their new function signatures.PCHARs instead ofPWCHARs.