Open
Conversation
Author
|
Small edit: I've corrected the license field in the rockspec to |
57227aa to
051efaa
Compare
Owner
|
Thank you for your contribution. Is this PR ready to merge? I'm sorry to say, I don't have the time to review it myself. |
Author
Author
|
After merging I also suggest to create a git tag (e.g. > luarocks new_version --dir rockspecs lunatic-python-scm-0.rockspec 1.0.0
> luarocks upload rockspecs/lunatic-python-1.0.0-1.rockspecThis will allow to install the rock directly via If you need assistance with any of that, feel free to ping me :) |
Author
|
Info: Today I noticed a regression in the luarocks-Makefile regarding the Lua include path when building on Debian. The regression is fixed with fe38122 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :) This PR adds a package definition for LuaRocks and adds compatibility for Python 3.11+.
I took the liberty to prepare a demo rock under https://luarocks.org/modules/leso-kn/lunatic-python, so you can try out the PR from my unmerged feature branch using:
> luarocks install lunatic-pythonPython can then be used from inside Lua, e.g.:
In case you prefer to not include this or when it gets merged, I'll of course delete my version on luarocks.org so you can upload under the package name 'lunatic-python'.
Thanks for keeping this project up!