primitive booleans instead of Booleans#365
primitive booleans instead of Booleans#365pemmasanikrishna wants to merge 1 commit intoaws-cloudformation:masterfrom
Conversation
| private Boolean snapshotRequested; | ||
| private Boolean rollback; | ||
| private Boolean driftable; | ||
| private boolean snapshotRequested; |
There was a problem hiding this comment.
I would suggest don't change the property type as it will cause method change and it will cause compile error.
As suggest in #341 (comment), we can provide extra helper method, such as isSnapshotRequested to simplify it.
There was a problem hiding this comment.
@wbingli I have already taken care of that change and changed the references as well. And the pr got build is successful. Do yoy want me to revert the change and provide helper method ?
There was a problem hiding this comment.
The point is that anyone who uses this class will be broken. The java plugin can build successful doesn't mean it won't break others. Therefore, I suggest to add helper method in the class instead of change the field type.
favor primitive types over boxed Boolean.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.