Changing view.x / view.y positions viewport correctly#6
Open
joaBaur wants to merge 7 commits intoawayjs:masterfrom
joaBaur:master
Open
Changing view.x / view.y positions viewport correctly#6joaBaur wants to merge 7 commits intoawayjs:masterfrom joaBaur:master
joaBaur wants to merge 7 commits intoawayjs:masterfrom
joaBaur:master
Conversation
Not sure if this._pRenderer._pStageGL.x / .y is the best way to access these StageGL properties
… null Line 95 of the iRegisterEntity function could be changed the same way, just to be sure (has not thrown an exception in my project yet)
…ition is null" This reverts commit 4d46be4.
When calling removeChild(), an "_iAssignedPartition ist NULL" is thrown when the child does not have an _explicitPartition set. This can be fixed by calling „this._pUpdateImplicitPartition(null);“ AFTER „this._iSetScene(null);“, so that the _pImplicitPartition of the child is not null also.
…ld()" This reverts commit 1e10ddf.
When calling renderer.queueSnapshot(), a buffer overrun („"ByteArray out of bounds read.“) is logged by ByteArray.readUnsignedInt() after 1/4 of the image data buffer has been processed. This happens because the bitmapData.setPixels() function calls inputByteArray.readUnsignedInt() 4 times within a loop iteration, where it should only request the unsigned int one time and split it into the RGBA components (like setPixel() and setPixel32() do). Also the loops had to be changed (the outer loop iterates over the y/height, the inner loop over the x/width), and the outer loop has to decrease the height value instead of increasing it, to compensate for the different y orientations of bitmaps and WebGL
The top and bottom caps were not rendered, because the faces/triangles were created with wrong indices (I compared the resulting indices array to the corresponding RawIndices array of the ActionScript CylinderPrefab to find the correct order)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this._pRenderer._pStageGL.x / .y is the best way to access
these StageGL properties