Use TypeScript and update immutable to version 4.0.0-rc.12#20
Open
nggonzalez wants to merge 5 commits intoavocode:masterfrom
Open
Use TypeScript and update immutable to version 4.0.0-rc.12#20nggonzalez wants to merge 5 commits intoavocode:masterfrom
nggonzalez wants to merge 5 commits intoavocode:masterfrom
Conversation
Update library to use typescript
Update Immutable to v4
Author
|
@avocode Would appreciate your review when you get a chance |
Author
|
Ping @avocode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modernize the library by adding Typescript and prettier, updating function names, creating smaller files, and updating dependencies.
Updates
immutableto the latest version (4.0.0-rc.12) and adds an option for AnonymousRecords when the recordType is not found.Changes
Iterable.isIterableto the newisCollectionmethod for determining if something is an immutableCollection(Map,Set,List,OrderedSet,OrderedMap,Stack)instanceof RecordtoRecord.isRecordfor checking if something is aRecordrecord.toMap()and userecord.toSeq()to iterate through key/value pairsthrowOnMissingRecordTypewhich defaults totrue. Whenfalse, this option will enable the creation ofAnonymousRecords that contain all of the data keys found in the initially decodedData.