Open
Conversation
Currently if I want to generate an API token for an API using the Auth0::Client, I must do the following:
```ruby
client = Auth0::Client.new(api_identifier: "my-api-identifier", **options)
api_token = client.api_token("my-api-identifier")
do_something(api_token) # Make a request to this API with the api token as the Authorization bearer.
```
However `Auth0::Client.new` will actually already request this api token on initialize, however this token is not available via any public interface.
This commit moves the `Auth0::Client#get_token` to a public method (formerly private).
Now when in need of any API token for an API, we can do the following:
```ruby
client = Auth0::Client.new(api_identifier: "my-api-identifier", **options)
api_token = client.get_token # No need for redundant request to `/oauth/token`.
do_something(api_token) # i.e make an http request to this API using the API token as the Authorization bearer.
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Code Changes
Make
Auth0::Client#get_tokenpublic.Why
Currently if I want to generate an API token for an API using the
Auth0::Client, I must do the following:However
Auth0::Client.newwill actually already request this api token on initialize, however this token is not available via any public interface. It is only stored as an instance variable in@token.This commit makes
Auth0::Client#get_tokenpublic (formerly private).Now when in need of an API token for the API, we can do the following:
Why not make
@tokenanattr_reader?#get_tokenhandles generating a new api token if the existing one has expired, saving me from having to handle that logic myself.References
None
Testing
There already are tests for this method
#get_token, I have just changed the tests to no longer usesendas the method is public now.Checklist