Open
Conversation
Author
|
All code was written using TypeScript. Nowadays, promises are widely used for asynchronous work. Do you think we should keep support for callbacks or only promises? in version ^10 |
|
Nice work brother, good luck! |
|
good job. |
Author
|
This package rewritten in typescript include types. |
Author
|
You must finish testing today to commit all changes. |
|
up |
|
Good! |
Author
|
Support for nodejs 12, 14 and 16 may be discontinued as these versions have already become obsolete. |
|
good job, this is fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add typescript and add support for es modules and commonjs
References
#843 #963 #875 #707
Testing
Checklist