Merged
Conversation
Contributor
|
Thank you for the PR. Lets improve PR title to something like Lets improve PR description to something like: Finally it helps if you mentions it's tested on hardware and what specific hardware.. And also squash commits, unless it makes sense to have separate ones. Buenos tardes y gracias! |
5b8792d to
92dc9ee
Compare
Author
92dc9ee to
f3f4721
Compare
petermm
reviewed
Jan 17, 2026
ssd1306_display_driver.c
Outdated
| #define CHAR_WIDTH 8 | ||
|
|
||
| #define I2C_ADDRESS 0x3C | ||
| #define I2C_CHUNK_SIZE 64 |
Contributor
There was a problem hiding this comment.
I2C_CHUNK_SIZE is not used anywhere, so let's remove line.
petermm
suggested changes
Jan 17, 2026
Contributor
petermm
left a comment
There was a problem hiding this comment.
Tested ssd1306 on simulator, as working.. so LGTM besides that stray I2C_CHUNK_SIZE
petermm
reviewed
Jan 17, 2026
ssd1306_display_driver.c
Outdated
| i2c_master_write_byte(cmd, 0xAD, true); // Internal IREF Setting | ||
| i2c_master_write_byte(cmd, 0x10, true); // Internal Iref | ||
|
|
||
| i2c_master_write_byte(cmd, 0xAF, true); // Display ON |
Contributor
There was a problem hiding this comment.
this 0xAF is redundant as it's being sent later CMD_DISPLAY_ON for all displays..
This PR adds supporf for ssd1315 displays. ssd1315 is mostly compatible with ssd1306 drivers, but it has some small differences, such as requiring a special initialization sequence and needing an explicit column address reset when updating. I also increased the timeout window from 10 to 100, to fix this error i was getting: `E (1225) SSD1306: I2C write failed for display update: 0x107` [(a timeout)](https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-reference/error-codes.html) The initialization sequence is based on the one used in [u8g2](https://github.com/olikraus/u8g2/blob/dbd338af5d57b219e48ea1ffdb97c4153668676c/csrc/u8x8_d_ssd1315_128x64_noname.c). Tested on an ESP32.
b253671 to
b937a15
Compare
petermm
approved these changes
Jan 18, 2026
bettio
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds supporf for ssd1315 displays. ssd1315 is mostly compatible with ssd1306 drivers, but it has some small differences, such as requiring a special initialization sequence and needing an explicit column address reset when updating.
I also increased the timeout window from 10 to 100, to fix this error i was getting:
E (1225) SSD1306: I2C write failed for display update: 0x107(a timeout)The initialization sequence is based on the one used in u8g2.
Tested on an ESP32.