Skip to content

Potential fix for code scanning alert no. 2: HTTP response splitting #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davewichers wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Potential fix for code scanning alert no. 2: HTTP response splitting #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ebb23
Potential fix for code scanning alert no. 2: HTTP response splitting
davewichers Feb 4, 2026
3a30edd
Fix formatting.
davewichers Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/main/java/org/owasp/benchmark/testcode/Benchmark00087.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,18 @@ public class Benchmark00087 extends HttpServlet {

private static final long serialVersionUID = 1L;

/**
* Sanitize a value for safe use as a cookie value by removing CR, LF and other non-printable
* control characters that could enable header splitting.
*/
private static String sanitizeForCookie(String value) {
if (value == null) {
return null;
}
// Remove CR, LF and other control characters (0x00-0x1F and 0x7F)
return value.replaceAll("[\\x00-\\x1F\\x7F]", "");
}

@Override
public void doGet(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
Expand Down Expand Up @@ -86,7 +98,8 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
str = new String(input, 0, i);
}
if ("".equals(str)) str = "No cookie value supplied";
javax.servlet.http.Cookie cookie = new javax.servlet.http.Cookie("SomeCookie", str);
String safeStr = sanitizeForCookie(str);
javax.servlet.http.Cookie cookie = new javax.servlet.http.Cookie("SomeCookie", safeStr);

cookie.setSecure(false);
cookie.setHttpOnly(true);
Expand Down