[BUGFIX] Track allocated size in response and prevent double-free in cleanup#35
Merged
[BUGFIX] Track allocated size in response and prevent double-free in cleanup#35
Conversation
- Add comprehensive test suite for connection pool edge cases - Test empty body responses after multiple non-empty body requests - Test alternating request patterns and stress scenarios - Verify fix for SSL double-free crash (SIGABRT) - All 5 tests pass, confirming the bug is fixed
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- test_double_free_bug_reproduction() now first test, most important - Documents exact bug scenario and crash conditions - Uses real httpmorph-bin server with /status/200 empty body endpoint - Triggers Connection: close -> pool_connection_destroy -> double-free - Without fix: crashes with SIGABRT (exit code 134) - With fix: passes successfully - All 6 connection pool tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cleanup