Fix -Wshadow warning for Interrupt callbacks#258
Open
earlephilhower wants to merge 1 commit intoarduino:masterfrom
Open
Fix -Wshadow warning for Interrupt callbacks#258earlephilhower wants to merge 1 commit intoarduino:masterfrom
earlephilhower wants to merge 1 commit intoarduino:masterfrom
Conversation
Adding -Wshadow to builds identified a template for the Interrupt callback which used a local variable the same as the class variable. Rename the local variable to not shadow the class one and make GCC happier.
Contributor
Author
|
Unit tests looks like it's failing in some other part of the CI infra not related to the 2-line patch here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding -Wshadow to builds identified a template for the Interrupt callback which used a local variable the same as the function parameter. Rename the local variable to not shadow the parameter and make GCC happier.
The GCC warning for
-Wshadowis as follows: