Skip to content

Conversation

@macdonst
Copy link
Contributor

@macdonst macdonst commented Jan 7, 2026

Thank you for helping out! ✨

We really appreciate your commitment to improving Architect

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

  • Forked the repo and created your branch from main
  • Made sure tests pass (run npm it from the repo root)
  • Expanded test coverage related to your changes:
    • Added and/or updated unit tests (if appropriate)
    • Added and/or updated integration tests (if appropriate)
  • Updated relevant documentation:
  • Summarized your changes in changelog.md
  • Linked to any related issues, PRs, etc. below that may relate to, consume, or necessitate these changes

This PR adds support for the timezone property. Instead of using AWS::Events::Rule it updates scheduled functions to use AWS::Scheduler::Schedule which supports setting a timezone.

All existing tests pass and added new test coverage.

Did manual testing by deploying a scheduled function with the following arc:

@scheduled
log-sweep
  cron 30 16 ? * * *
  src log-sweep
  timezone America/New_York

and was able to verify in CloudWatch logs that it did run at 4:30pm in the Eastern timezone.

Signed-off-by: Simon MacDonald <simon.macdonald@gmail.com>
Signed-off-by: Simon MacDonald <simon.macdonald@gmail.com>
@macdonst
Copy link
Contributor Author

macdonst commented Jan 7, 2026

Oh, I forgot to mention that the tests will fail until the changes to inventory get published.

Resolved

Signed-off-by: Simon MacDonald <simon.macdonald@gmail.com>
Signed-off-by: Simon MacDonald <simon.macdonald@gmail.com>
Signed-off-by: Simon MacDonald <simon.macdonald@gmail.com>
@brianleroux brianleroux merged commit 64b1721 into main Jan 15, 2026
15 checks passed
@brianleroux brianleroux deleted the scheduled-timezone branch January 15, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants