Fix file ordering, deprecated warning, and improve PLY save performance#75
Open
hafeezhmha wants to merge 1 commit intoapple:mainfrom
Open
Fix file ordering, deprecated warning, and improve PLY save performance#75hafeezhmha wants to merge 1 commit intoapple:mainfrom
hafeezhmha wants to merge 1 commit intoapple:mainfrom
Conversation
Fixes apple#63 Addresses apple#74 (partial) This PR fixes three issues: 1. Random file order processing (apple#63) Added sorting to file path collection in predict and render commands. Files are now processed in alphabetical order instead of random filesystem order. Important for sequential workflows like video frames. 2. Deprecated logger.warn Replaced logger.warn() with logger.warning() in io.py to remove the deprecation warning. 3. PLY save performance (apple#74 partial fix) Optimized the array construction in save_ply by using np.core.records.fromarrays() instead of list(map(tuple, ...)). Also moved tensor CPU transfers earlier. Benchmark results: 8x faster PLY saving (40ms -> 5ms for 10k Gaussians). This saves about 3-4 seconds on the full pipeline for typical scenes. Note: This doesn't fix the main bottleneck in apple#74 (ViT initialization takes ~6s). Tested on Linux. All changes are backward compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63, addresses #74 (partial)
Three small fixes:
File ordering (random file order processing #63)- Sort file paths in predict/render commands so files process in order instead of random. Helps with video frames and sequential data.
Deprecated warning - Replace deprecated
logger.warnwithlogger.warningin io.pyPLY save performance (Processing time over 30s for a single image #74 partial)** - Speed up PLY saving by using np.core.records.fromarrays instead of
list(map(tuple, ...)).Tested on Linux