fix(VideoWriter): close depth_writer in close() method#73
Open
billybjork wants to merge 1 commit intoapple:mainfrom
Open
fix(VideoWriter): close depth_writer in close() method#73billybjork wants to merge 1 commit intoapple:mainfrom
billybjork wants to merge 1 commit intoapple:mainfrom
Conversation
The VideoWriter class was not closing the depth video writer, causing corrupted/unplayable depth map video files. The imageio writer requires close() to be called to finalize the video file. Changes: - Initialize self.depth_writer = None before conditional assignment (fixes potential AttributeError when render_depth=False) - Add depth_writer.close() call in close() method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
VideoWriterclass was not closing the depth video writer in itsclose()method, causing depth map video files (.depth.mp4) to be corrupted/unplayable.Problem
When using
VideoWriterwithrender_depth=True, the depth video files are never finalized becauseclose()only closesimage_writer:The
imageiowriter requiresclose()to be called to write the video file headers and finalize the container.Fix
self.depth_writer = Nonebefore the conditional assignment (also fixes a potentialAttributeErrorifrender_depth=Falseand code elsewhere checksself.depth_writer)depth_writerin theclose()method if it existsTesting
Verified that depth map videos are now playable after this fix.