WICKET-6993 - Resource Variations containing a single character are not correctly decoded#529
Open
Serranya wants to merge 7 commits intoapache:masterfrom
Open
WICKET-6993 - Resource Variations containing a single character are not correctly decoded#529Serranya wants to merge 7 commits intoapache:masterfrom
Serranya wants to merge 7 commits intoapache:masterfrom
Conversation
Serranya
force-pushed
the
master
branch
3 times, most recently
from
a82f546 to
7bd0b63
Compare
Contributor
Author
|
Ready to review :) |
added 6 commits
July 4, 2022 08:44
We prepare the refactor of the resource encoding by adding new methods for encoding and decoding the parts of an resource
We can now use the encoding mechanism introduced in the previous commit to simplify the encoding and decoding of the entire resource attributes.
This test is the only usage in the code of the old escape methods. We remove it in preparation for the next commit which removes the old escape methods entirely.
These are not used in the code anymore
Contributor
Author
|
Hello, could I get any feedback regarding this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new Resource attribute encoding scheme inspired by the string encoding of the
bencodeformat.