TRUNK-5119 : Added backward compatability lines to velocity.properties file#61
Open
reshma2004 wants to merge 2 commits intoapache:masterfrom
Open
TRUNK-5119 : Added backward compatability lines to velocity.properties file#61reshma2004 wants to merge 2 commits intoapache:masterfrom
reshma2004 wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding the issue TRUNK-5119,
https://openmrs.atlassian.net/issues?filter=10665&selectedIssue=TRUNK-5119
I checked if velocity versions are already updated though out the project. And found they are already updated.
To maximize backward compatibility of Velocity 2.5 with Velocity 1.x, I have include the 4 lines in your Velocity configuration as mentioned in this link in the main folder velocity-engine\velocity-engine-core\src\main\resources\org\apache\velocity\runtime\default\velocity.properties :
I also modified velocimacro.enable_bc_mode = true as it was conflicting with the above configuration.
I have tested locally to ensure build was success.
https://velocity.apache.org/engine/2.1/upgrading.html#dependencies-changes