refactor the velocity with a more scalable api and spi interfaces#25
Draft
xiaoma20082008 wants to merge 2 commits intoapache:masterfrom
Draft
refactor the velocity with a more scalable api and spi interfaces#25xiaoma20082008 wants to merge 2 commits intoapache:masterfrom
xiaoma20082008 wants to merge 2 commits intoapache:masterfrom
Conversation
michael-o
requested changes
Sep 14, 2021
Author
Got it, Thank you! |
|
This api looks alot like handlebars. this is pretty slick. |
5efa30a to
c223157
Compare
c223157 to
3583a4b
Compare
Author
|
I was fired after i started on this issues, and lost many commits on my old computer as it's belong to the company, I'll restart now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to refactor the velocity with a more scalable API (for Users) and SPI (for Developers), but I don't know whether it's needed, So I created this pr for ensure it (Please tell me if you need otherwise please close this pr, Thank you! ).
The target is:
The sample usage For User:
Sample Implementation is: