[UIMA-5964] avoid null value of unsorted variable.#1
Open
fanavarro wants to merge 1 commit intoapache:trunkfrom
fanavarro:UIMA-5964
Open
[UIMA-5964] avoid null value of unsorted variable.#1fanavarro wants to merge 1 commit intoapache:trunkfrom fanavarro:UIMA-5964
fanavarro wants to merge 1 commit intoapache:trunkfrom
fanavarro:UIMA-5964
Conversation
tanenblatt
reviewed
Jan 21, 2019
tanenblatt
left a comment
tanenblatt
left a comment
There was a problem hiding this comment.
After going through the code manually, it does appear that the proposed change should do the right thing. I’ve been trying to figure out why that was never a reported problem, but I guess it was because when not using sorting, the array of matched tokens can be consulted to compute the matched string. Making this change would therefore be a reasonable convenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the bug [UIMA-5964]. Matched text field of concept mapper was always null when OrderIndependentLookup is false. With this fix, matched text is initialized independently of OrderIndependentLookup.