Skip to content

Conversation

@sgjzfzzf
Copy link

@sgjzfzzf sgjzfzzf commented Feb 2, 2026

Triton call will return the CompiledKernel directly to get the cubin. The previous code searches the cubin by cache, which is unnecessary and not robust.

This PR refactors that by taking compiled_kernel directly from the Triton kernel call.

Signed-off-by: Jinjie Liu <jjliu@baai.ac.cn>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sgjzfzzf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the method of acquiring a CompiledKernel instance after a Triton kernel execution. Previously, the code would perform a dummy kernel call and then manually search through Triton's internal device caches to retrieve the compiled kernel. The updated approach leverages a change where the Triton kernel call now directly returns the CompiledKernel object, simplifying the code, enhancing its reliability, and removing an indirect and potentially fragile lookup mechanism.

Highlights

  • Direct CompiledKernel Retrieval: The pull request modifies the examples to directly obtain the CompiledKernel object from the return value of a Triton kernel call, rather than extracting it from internal device caches.
  • Simplified CUBIN Extraction: This change removes the previous, more complex logic of iterating through device_caches to find the compiled kernel, streamlining the process of getting CUBIN bytes.
  • Improved Robustness: By directly receiving the CompiledKernel, the code becomes more robust as it no longer relies on the internal structure or search mechanism of the device cache, which the PR description notes was 'unnecessary and not robust'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the way CompiledKernel is obtained from a Triton kernel call. The previous method of accessing the internal device cache was brittle and relied on implementation details. The new approach, which gets the CompiledKernel directly from the return value of the kernel launch, is much cleaner, more robust, and simplifies the code significantly in both benchmark_overhead.py and example_triton_cubin.py. The changes are correct and represent a good improvement in code quality and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant