TEZ-4518: Added capability to limit number of spill files being generated#312
Open
mudit1289 wants to merge 1 commit intoapache:masterfrom
Open
TEZ-4518: Added capability to limit number of spill files being generated#312mudit1289 wants to merge 1 commit intoapache:masterfrom
mudit1289 wants to merge 1 commit intoapache:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Author
|
@abstractdog @ayushtkn can you please review this |
This comment was marked as outdated.
This comment was marked as outdated.
|
🎊 +1 overall
This message was automatically generated. |
abstractdog
reviewed
Jan 4, 2024
| * the max limit on spill files being generated by the job. | ||
| * If limit is reached, this function throws an IOException | ||
| */ | ||
| private void incrementNumSpills() throws IOException { |
Contributor
There was a problem hiding this comment.
shouldn't this duplicated logic go to ExternalSorter instead of all children (PipelinedSorter, DefaultSorter)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASF Jira: https://issues.apache.org/jira/browse/TEZ-4518
We have been facing some issues where many of our cluster node disks go full because of some rogue applications creating a lot of spill data
We wanted to fail the app if more than a threshold amount of spill files are written
In this PR, we are trying to introduce a config to limit the count of sort spill files being written by a container