[DRAFT] TEZ-4505: Create counters about time intervals spent in certain states in StateMachineTez#304
Open
abstractdog wants to merge 1 commit intoapache:masterfrom
Open
[DRAFT] TEZ-4505: Create counters about time intervals spent in certain states in StateMachineTez#304abstractdog wants to merge 1 commit intoapache:masterfrom
abstractdog wants to merge 1 commit intoapache:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…s in StateMachineTez
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
reviewed
Sep 14, 2023
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
Sounds cool to me, I think you need to add some test around it as well
|
|
||
| private boolean isStateIntervalMonitorEnabled = false; | ||
| private long lastStateChangedTime = Time.monotonicNow(); | ||
| private Map<String, Long> intervalSpentInStatesMs = new HashMap<>(); |
| private final StateMachine<STATE, EVENTTYPE, EVENT> realStatemachine; | ||
|
|
||
| private boolean isStateIntervalMonitorEnabled = false; | ||
| private long lastStateChangedTime = Time.monotonicNow(); |
Member
There was a problem hiding this comment.
shouldn't this be set as part of enableStateIntervalMonitor?
| } | ||
| } | ||
|
|
||
| private void maybeMergeAllTaskAttemptCounters(TezCounters taskCounters) { |
Member
There was a problem hiding this comment.
nit
I think we can ditch maybe from the name & just have mergeAllTaskAttemptCounters(, if stateIntervalMontior is enabled it does merge always
| */ | ||
| package org.apache.tez.common.counters; | ||
|
|
||
| public class TaskAttemptCounter { |
Member
There was a problem hiding this comment.
I couldn't decode the usage of this 'empty' class, we are only using the name of this class, if only name is required can't we have a string constant or an enum
Contributor
Author
There was a problem hiding this comment.
this is just a leftover, actually I'm in the middle of this, full of bugs, let me set this PR to [DRAFT]
abstractdog
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.