[SYSTEMDS-3259] Implementation of the shampoo optimizer (initial prototype)#2401
Merged
christinadionysio merged 2 commits intoapache:mainfrom Feb 2, 2026
Merged
[SYSTEMDS-3259] Implementation of the shampoo optimizer (initial prototype)#2401christinadionysio merged 2 commits intoapache:mainfrom
christinadionysio merged 2 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
============================================
- Coverage 71.51% 71.50% -0.01%
+ Complexity 47441 47433 -8
============================================
Files 1539 1539
Lines 182605 182605
Branches 35916 35916
============================================
- Hits 130585 130573 -12
- Misses 42028 42032 +4
- Partials 9992 10000 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thank you for the patch @NicolasKorjahn! Could you add the missing licenses and then I would merge it in. For your follow-up experiments etc. you can then create a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Shampoo optimizer support for neural network training in SystemDS.
Includes full-matrix and diagonal preconditioning, momentum updates, and a heuristic variant with delayed preconditioner updates / infrequent root recomputation. Extend the existing NN training scripts with tests to validate correctness and convergence.
Tests: src/test/scripts/applications/nn/component/shampoo_test.dml
src/test/scripts/applications/nn/component/shampoo_test2.dml
src/test/scripts/applications/nn/component/shampoo_test.py
Experiments in staging/shampoo_optimizer