Make busybox securityContext configurable#649
Draft
janhoy wants to merge 1 commit intoapache:mainfrom
Draft
Conversation
Contributor
Author
|
Alternatively, should perhaps the spec for spec:
cpSolrXmlInitContainer:
image:
registry: public.ecr.aws
repository: my-company/busybox
tag: 1.37.0-custom
imagePullSecret: foo
securityContext:
runAsUser: 1000
runAsGroup: 1000PS: By splitting image into registy, repository and tag, it is easier for downstream users to customize just the registry part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR, only code, not docs, no helm support.
The
busyboxofficial image runs as root incp-solr-xmlinit-container, and there is no way to configure it otherwise, other than point to a different image that has been manipulated as non-root.By adding a
SecurityContextfor the init container defaulting to thenobodyuser and settingrunAsNonRoot: true, we have a good default. By also making thesecurityContextconfigurable, we allow for people to switch to a different image with other UID etc. Example:Fixes #582