SINGA-270 Installation error: include/singa/proto/ is not in /usr/local/include#282
SINGA-270 Installation error: include/singa/proto/ is not in /usr/local/include#282xiezl wants to merge 2 commits intoapache:masterfrom
Conversation
…al/include Fix the installation path of include/singa/proto.
|
I tried the PR. The directory /usr/local/include/singa/proto/ exists now, but there is a compile error when I try to compile test.cpp from #272 : $ g++ ./test.cpp -l singa |
…al/include Fix dependent lib installation. Add a new option to disable glog usage.
|
The problem is caused by using two different protobuf libs. |
|
Ok. I think the problem is fixed now and the PR can be merged. Thank you. |
| OPTION(USE_CUDNN "Use Cudnn libs" ON) | ||
| OPTION(USE_OPENCV "Use opencv" OFF) | ||
| OPTION(USE_LMDB "Use LMDB libs" OFF) | ||
| OPTION(USE_GLOG "Use glog libs" ON) |
There was a problem hiding this comment.
Do we need this one?
I think we agreed to remove it and use it if cmake can detect it.
There was a problem hiding this comment.
If cmake detects glog, then we link glog statically into libsinga.so.
In this way, we would not have the linking error when compiling user code.
Fix the installation path of include/singa/proto.