RANGER-5466 Avoid hardcoded delta sync and unnecessary LDAP filter when delta sync is disabled #827
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en delta sync is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
setup.py: Changed hardcoded
ranger.usersync.ldap.deltasync=trueto only set the default value when the property is not already configured in install.properties.LdapUserGroupBuilder: Skip appending delta sync filter conditions (uSNChanged, modifyTimestamp) to LDAP search queries when delta sync is disabled. Applied to both getUsers() and getGroups()
Some LDAP services (e.g., Google Workspace Secure LDAP) do not support the attributes used for delta sync (uSNChanged, modifyTimestamp), which causes delta sync to not work properly. In such cases, users should be able to disable delta sync and run full sync without unnecessary filter conditions being included in the LDAP queries.
How was this patch tested?