PHOENIX-7755 Add support for Consistency Point calculation in Replication Log Replay on StandBy Cluster #2356
+758
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Himanshu-g81
force-pushed
the
PHOENIX-7755-consistency-point-impl
branch
from
214ae38 to
d2e0c49
Compare
tkhurana
reviewed
Feb 9, 2026
| import org.apache.phoenix.thirdparty.com.google.common.collect.Maps; | ||
|
|
||
| @Category(NeedsOwnMiniClusterTest.class) | ||
| public class ReplicationLogReplayServiceTestIT extends BaseTest { |
Contributor
There was a problem hiding this comment.
Can you instead extend from HABaseIT ? Trying to ensure that all HA ITs extend the same base class. Feel free to enhance it.
Contributor
Author
There was a problem hiding this comment.
Sure, looks like it's recently added. Have updated this class to extend HABaseIT instead. Thanks.
tkhurana
reviewed
Feb 9, 2026
| } | ||
|
|
||
| @After | ||
| public void tearDown() throws IOException { |
Contributor
Author
There was a problem hiding this comment.
We are not creating any file so not required, have removed it. Thanks.
tkhurana
reviewed
Feb 9, 2026
| private PhoenixHAAdmin peerHaAdmin; | ||
|
|
||
| @Rule | ||
| public TestName testName = new TestName(); |
Contributor
There was a problem hiding this comment.
The convention we are following in other ITs is to use testName.getMethodName as the HA group name. This way each test creates its own HA group and there is no interference from one test to another.
added 5 commits
February 10, 2026 11:38
Himanshu-g81
force-pushed
the
PHOENIX-7755-consistency-point-impl
branch
from
4ce2c75 to
dab2b12
Compare
Contributor
Author
|
Force push due to rebase with upstream branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definition of consistency point - https://docs.google.com/document/d/1usap8PCYFU0Z4orznUPvk0tnSv0X-vnbgD_QZejrnv0/edit?tab=t.0#bookmark=id.c1dczn86acar
Note: The lastRoundInSync & lastRoundProcessed are already initialized based on cluster state, i.e. (DEGRADED / sync replication) when RS starts (code reference) - including fetching the last round in sync from HA Store if cluster is in DEGRADED state.