Conversation
Contributor
Author
|
Removing JDK21 because Spotless is not compatible yet, and we can't update because of dropped JDK8 support. Also, Hadoop 3.3.0 does not support JDK21. |
gszadovszky
reviewed
Sep 16, 2025
gszadovszky
reviewed
Sep 16, 2025
pom.xml
Outdated
Comment on lines
72
to
73
| <maven.compiler.source>11</maven.compiler.source> | ||
| <maven.compiler.target>11</maven.compiler.target> |
Contributor
There was a problem hiding this comment.
I think we should start using maven.compiler.release instead.
gszadovszky
approved these changes
Sep 17, 2025
|
What's the status of this PR? It's blocking #3182 which is necessary to use recent protobuf versions. I'm trying to prepare a PR to upgrade |
Contributor
Author
|
Result of the thread on the dev-list: https://lists.apache.org/thread/cblz22jgllyvw2t63xs3fbzxcvhy5y42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See dev-list: https://lists.apache.org/thread/cblz22jgllyvw2t63xs3fbzxcvhy5y42
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?