ORC-2078: Fix TestConverter to respect test.tmp.dir#2516
Closed
dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
Closed
ORC-2078: Fix TestConverter to respect test.tmp.dir#2516dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
TestConverter to respect test.tmp.dir#2516dongjoon-hyun wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
Merged to main/2.2. |
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 6, 2026
### What changes were proposed in this pull request? This PR aims to fix `TestConverter` to respect `test.tmp.dir`. ### Why are the changes needed? To avoid generating temporary files in a wrong place. It makes `git` confused like the following. ``` $ cd java $ mvn package $ git status On branch main Your branch is up to date with 'apache/main'. Untracked files: (use "git add <file>..." to include in what will be committed) tools/.test.csv.crc tools/test.csv nothing added to commit but untracked files present (use "git add" to track) ``` ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: `Gemini 3 Pro (High)` on `Antigravity` Closes #2516 from dongjoon-hyun/ORC-2078. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 0dd2a6d) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 6, 2026
This PR aims to fix `TestConverter` to respect `test.tmp.dir`. To avoid generating temporary files in a wrong place. It makes `git` confused like the following. ``` $ cd java $ mvn package $ git status On branch main Your branch is up to date with 'apache/main'. Untracked files: (use "git add <file>..." to include in what will be committed) tools/.test.csv.crc tools/test.csv nothing added to commit but untracked files present (use "git add" to track) ``` Pass the CIs. Generated-by: `Gemini 3 Pro (High)` on `Antigravity` Closes #2516 from dongjoon-hyun/ORC-2078. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 0dd2a6d) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 6, 2026
This PR aims to fix `TestConverter` to respect `test.tmp.dir`. To avoid generating temporary files in a wrong place. It makes `git` confused like the following. ``` $ cd java $ mvn package $ git status On branch main Your branch is up to date with 'apache/main'. Untracked files: (use "git add <file>..." to include in what will be committed) tools/.test.csv.crc tools/test.csv nothing added to commit but untracked files present (use "git add" to track) ``` Pass the CIs. Generated-by: `Gemini 3 Pro (High)` on `Antigravity` Closes #2516 from dongjoon-hyun/ORC-2078. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
changed the title
TestConverter to respect test.tmp.dirTestConverter to respect test.tmp.dir
dongjoon-hyun
changed the title
TestConverter to respect test.tmp.dirTestConverter to respect test.tmp.dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix
TestConverterto respecttest.tmp.dir.Why are the changes needed?
To avoid generating temporary files in a wrong place. It makes
gitconfused like the following.How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by:
Gemini 3 Pro (High)onAntigravity