Conversation
|
Thanks @zxf216! Let me take a first pass. cc @coderex2522 @ffacs |
|
|
I converted it to |
wgtmac
left a comment
There was a problem hiding this comment.
Thanks @zxf216 again for the excellent work! I just took a preliminary look and have left some inline comments. As you can see that we have various CI jobs for test cases, code format, license check, etc. I strongly recommend splitting the PR into smaller ones to make the review process easier.
c++/src/TypeImpl.cc
Outdated
| } | ||
| return nullptr; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please revert the unnecessary change.
| struct ReaderOptionsPrivate; | ||
| struct RowReaderOptionsPrivate; | ||
|
|
||
| class KeyProvider; |
There was a problem hiding this comment.
The c++/include/orc folder is public and files in it will be installed. If the KeyProvider is also public, please move its definition to the include folder as well. Otherwise, we should remove the related function from here.
| @@ -0,0 +1,247 @@ | |||
| // Copyright 2010-present vivo, Inc. All rights reserved. | |||
There was a problem hiding this comment.
Please note that we have a license check which does not allow custom modification to the license header in this repo. I'm not sure if this violates any ASF rule to add something like this. @dongjoon-hyun Do you have any concern?
| std::shared_ptr<SecretKeySpec> getStripeKey(long stripe); | ||
| }; | ||
|
|
||
| // 加密变体,每个列一个 |
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
Co-authored-by: Gang Wu <ustcwg@gmail.com>
|
Gentle ping, @zxf216 . |
What changes were proposed in this pull request?
you can use C++ version code to read encrypted ORC files
ORC file structure:links
Why are the changes needed?
The C++ version is not yet able to read encrypted ORC files now
How was this patch tested?