KYLIN-5748 Skip build flat table for index build job if all new created indexes can be built from existed parent index#2162
Open
zznlime wants to merge 3 commits intoapache:kylin5from
Open
KYLIN-5748 Skip build flat table for index build job if all new created indexes can be built from existed parent index#2162zznlime wants to merge 3 commits intoapache:kylin5from
zznlime wants to merge 3 commits intoapache:kylin5from
Conversation
…ed indexes can be built from existed parent index
…ed indexes can be built from existed parent index
Contributor
Author
|
@hit-lacus PTAL, Thanks |
Contributor
|
Your proposal will be invalid in this use case: if you add a new bitmap type metric to the model, you can build the new index separately, and the task type is also INDEX_BUIDL. If you skip building the dictionary, an error will occur when generating encoding columns for the flat table later. |
Contributor
|
@zznlime Does this pr need to be merged into the kylin code? If necessary, please send pr to @liyang-kylin . I will resolve this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an index build job, if all the new added indexes can be built from their existed parent index. No index was built from new created flat table.
For this case, there won't be any data inconsistency across indexes. And there is no need to build a new flat table to serve the stage of index build by layer.
So I think we can skip stage BUILD DICT and stage GENERATE FLAT TABLE for an index build job in condition that all new added indexes can be built from their existed parent index