Open
Conversation
Mukvin
reviewed
Dec 27, 2022
| try { | ||
| if (StringUtils.isNotBlank(pattern)) { | ||
| SimpleDateFormat sdf = new SimpleDateFormat(pattern, Locale.getDefault(Locale.Category.FORMAT)); | ||
| sdf.setTimeZone(TimeZone.getTimeZone("GMT")); |
Contributor
There was a problem hiding this comment.
This is hard code for timezone, please reference to org.apache.kylin.common.KylinConfigBase#getTimeZone
| SegFilters(tsRange.startValue, tsRange.endValue, pattern) | ||
| // tsRange: 20221219000000_20221219010000、20221219010000_20221219020000, pattern: yyyy-MM-dd | ||
| val start = DateFormat.getFormatTimeStamp(tsRange.startValue, pattern) | ||
| SegFilters(start, tsRange.endValue, pattern) |
Contributor
There was a problem hiding this comment.
how about tsRange.endValue? is it same as start?
Author
There was a problem hiding this comment.
tsRange.endValue 不需要考虑，DateFormat.getFormatTimeStamp(tsRange.startValue, pattern) 这个的作用是将 startValue 格式化成天的时间戳值（忽略小时），原因是 SegFilters 的 foldFilter 中是按天格式化where 分区字段值的（记作ts），后续比较也是 “ts >= start && ts < end” end 如果是到时间其对应的时间戳一定是大于天的时间戳值因而可以不用处理。
Contributor
There was a problem hiding this comment.
As for clearance, please comment on the place of tsRange.endValue then help others to understand.
Author
|
|
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
创建model时在partition部分指定了天分区和时分区，格式分别为：yyyy-MM-dd、HH，在根据天分区值查询时结果非预期。原因是这种场景下segment裁剪有bug。
--不加天分区过滤得到的结果（18号3条数据，19号5条数据）
--加天分区在修复前查询结果
--18号实际有3条数据
--19号实际有5条数据
--18号19号共有8条数据
--加天分区在修复后查询结果
Branch to commit
Types of changes
What types of changes does your code introduce to Kylin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin.apache.org or dev@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...