-
Notifications
You must be signed in to change notification settings - Fork 3k
Add Kafka Connect artifact publish to release process #15212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "type": "organization", | ||
| "url": "https://iceberg.apache.org", | ||
| "username": "iceberg" | ||
| "username": "apache" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? Is there some reason this needs to be apache as opposed to iceberg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the package name then becomes apache-iceberg-kafka-connect instead of iceberg-iceberg-kafka-connect
| @@ -0,0 +1,27 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer that we use the name iceberg-sink.properties.template which is more consistent with hive/spark/etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 8a30ca2
| 2. Confluent will publish to the Marketplace | ||
|
|
||
| !!! Note | ||
| This step is optional and can be performed by any PMC member after the release is finalized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would this be optional? I would think if we're doing updates we always want artifacts updated in the marketplace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was erring on the side of caution :) I wasn't sure how the project would feel about it not being optional. I can word it differently if you'd like?
Background
There is currently no prebuilt Iceberg connector for Kafka Connect provided with Iceberg. This can make it more difficult than necessary for users who just want to build pipelines, not run gradle :)
Confluent Marketplace (previously "Confluent Hub") is a long-established platform for the distribution of connectors for Kafka Connect, both open-source and proprietary.
At the moment the 1.9.2 version of the connector has been uploaded to the site by Confluent staff as an ad-hoc process.
There are several existing issues from the community regarding: #10745 #14986 #12516
This PR
(replaces #15113)
This PR does two things: