Fixing bug with geode home determination#7550
Fixing bug with geode home determination#7550thesteve0 wants to merge 3 commits intoapache:developfrom
Conversation
If you place the product_dir in a path with "bin" in, the old method would ruin the path. For example `C:\Users\steve\bin\apache-geode-1.14.4\bin\` would become `C:\Users\steveapache-geode-1.14.4` This implementation cuts off the last 4 letters of the bin directory to get to the installation location.
thesteve0
requested review from
jdeppe-pivotal,
jinmeiliao,
kirklund and
mhansonp
as code owners
| setlocal enableextensions | ||
| set scriptdir=%~dp0 | ||
| set gf=%scriptdir:\bin\=% | ||
| set gf=%scriptdir:~0,-4% |
There was a problem hiding this comment.
Could you just add a short comment so anyone else, looking at this in the future, knows why 4 in particular. Maybe:
REM Remove last 4 chars corresponding to bin\
|
Changes made |
|
That concourse build failure does not look related to my change - how do I clear it? |
@thesteve0 You can either use: or if you have access to tanzu projects, you can trigger just precheckin for unit-test using: |
mhansonp
left a comment
mhansonp
left a comment
There was a problem hiding this comment.
Have you investigated why the unit tests are failing?
There are 37 failures - all of them Java exceptions some related to Mockito. I changed 1 line in a windows bat file. This seems to be something wrong with the test harness since I did not touch Java code |
onichols-pivotal
dismissed
mhansonp’s stale review
passing unit tests are already a prerequisite to merge.
re-trigger CI since new checks have been added
|
@JinwooHwang: Is it possible to re-run tests on this PR to determine if it now passes? |
|
Sure @semioticrobotic. Thanks for reviewing the PR. Let me start the checks. It appears that I don't have the permission to merge. Merging is blocked. |
8 participants
If you place the product_dir in a path with "bin" in, the old method would ruin the path. For example
C:\Users\steve\bin\apache-geode-1.14.4\bin\would become
C:\Users\steveapache-geode-1.14.4This implementation cuts off the last 4 letters of the bin directory to get to the installation location.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?