GEODE-10237: Remove no-ack from testThinClientTransactionsWithSticky#959
Open
mmartell wants to merge 2 commits intoapache:developfrom
Open
GEODE-10237: Remove no-ack from testThinClientTransactionsWithSticky#959mmartell wants to merge 2 commits intoapache:developfrom
mmartell wants to merge 2 commits intoapache:developfrom
Conversation
mmartell
force-pushed
the
GEODE-10237-fix-transactions-test
branch
from
ba07d13 to
fa70213
Compare
pdxcodemonkey
requested changes
May 2, 2022
Contributor
pdxcodemonkey
left a comment
pdxcodemonkey
left a comment
There was a problem hiding this comment.
This is, IMO, too much code to duplicate, and adding the new file rather than editing the existing one really obscures the nature of this change. Please try just editing ThinClientTrasactions.hpp and resubmit.
- no need for an additional header file - just refactor the original include file
Contributor
Author
Good catch Blake! Not sure why I thought I needed to use a new header file. As you point out, just needed to refactor the original header. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the no-ack functionality from this test, which fails regularly in the CI.