Open
Conversation
- add to new clicache test framework
pdxcodemonkey
requested changes
Mar 3, 2022
Contributor
pdxcodemonkey
left a comment
pdxcodemonkey
left a comment
There was a problem hiding this comment.
Please add at least one trivial integration test that exercises this code. Thanks for adding this, it will be helpful to improve our test coverage!
Contributor
Author
Modififed the existing StartServerStringsTest (in new test framework) to validate that .withGroups() adds the --groups arg to start server command. Also, we already have tests that exercise the --groups functionality on the client side: testXmlCacheCreationWithPools |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds serverGroups to new clicache test framework.