Add support for C-style comments #2034
Conversation
altmannmarcelo
force-pushed
the
c_style_comment
branch
4 times, most recently
from
4123881 to
e5de267
Compare
| } | ||
| #[test] | ||
| fn tokenize_multiline_comment_with_c_style_comment() { | ||
| let sql = String::from("0/*! word */1"); |
There was a problem hiding this comment.
Looking at their docs, I'm wondering if/how we support these examples?
SELECT /*! STRAIGHT_JOIN */ col1 FROM table1,table2
/*!50110 KEY_BLOCK_SIZE=1024 */
SELECT /*! BKA(t1) */ FROM TThere was a problem hiding this comment.
@iffyio - Parsing the c_style comment unblocks sqlparser to not discard those as if they were a normal comment. Support for each hint will have to be added in a case by case bases. For example #2033 - MySQL adds a c-style comment if you run SHOW CREATE TABLE:
mysql> SHOW CREATE TABLE b;
+-------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table | Create Table |
+-------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------+
| b | CREATE TABLE `b` (
`ID` int DEFAULT NULL,
`b` char(1) DEFAULT NULL /*!80023 INVISIBLE */
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci |
+-------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0,008 sec)
Without the current patch, the invisible keyword will be discarded.
There was a problem hiding this comment.
Ah so to clarify I'm rather wondering regarding the parser behavior for hints that aren't singe words e.g. /*!50110 KEY_BLOCK_SIZE=1024 */ - can we demonstrate the behavior with test cases for such scenarios?
There was a problem hiding this comment.
@iffyio thanks flagging this. I have fixed the issue and now we properly return individual tokens inside a C-style hint comment.
| } | ||
| #[test] | ||
| fn tokenize_multiline_comment_with_c_style_comment() { | ||
| let sql = String::from("0/*! word */1"); |
There was a problem hiding this comment.
Ah so to clarify I'm rather wondering regarding the parser behavior for hints that aren't singe words e.g. /*!50110 KEY_BLOCK_SIZE=1024 */ - can we demonstrate the behavior with test cases for such scenarios?
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
@altmannmarcelo sorry for the delay in getting back to this, left some comments!
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
|
I will pick this up in a few days. |
altmannmarcelo
force-pushed
the
c_style_comment
branch
from
f96249c to
f8df333
Compare
This commit adds support for comment hints supported by MySQL. It parses and consumes the optional version number after the `!` character and return all tokens inside a comment hint.
altmannmarcelo
force-pushed
the
c_style_comment
branch
from
f8df333 to
c9858ff
Compare
|
@iffyio sorry for my delay on getting back - I have implemented the re-tokenize function. |
2 participants
This commit adds support for C-style comments supported by MySQL. It parses and consumes the optional version number after the
!character.