Add debug logging for client port hijack failures in ZooKeeperServerE…#1273
Open
bigduu wants to merge 2 commits intoapache:masterfrom
Open
Add debug logging for client port hijack failures in ZooKeeperServerE…#1273bigduu wants to merge 2 commits intoapache:masterfrom
bigduu wants to merge 2 commits intoapache:masterfrom
Conversation
…mbeddedAdapter Add debug log for some specify situation to help developer identify the issue location
There was a problem hiding this comment.
Pull Request Overview
This PR adds debug logging to improve troubleshooting when ZooKeeper client port hijacking fails in the test framework. The change helps developers identify issues when the ZooKeeperServerEmbeddedImpl class cannot be found, which can lead to repeated startup attempts with the same port and confusing "address in use" errors.
Key Changes
- Enhanced exception handling in the
hijackClientPortmethod to capture and log hijack failures - Improved debugging capabilities for ZooKeeper server startup issues in unit tests
curator-test/src/main/java/org/apache/curator/test/ZooKeeperServerEmbeddedAdapter.java
Outdated
Show resolved
Hide resolved
…rverEmbeddedAdapter.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
I expect this should be covered by: How did you using it ? I expect people use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mbeddedAdapter
Add debug log for some specify situation to help developer identify the issue location
It's will eat the exception if can't find the
ZooKeeperServerEmbeddedImplclass in some case, it will makes keep trying startup the zk server with same port. so the unit test will throw the address in used without any useful info.This change add info for investigate