Fix the regex matching bug of the GUC gp_resource_group_cgroup_parent #1569
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a code defect of a original GPDB on resource group enabled. There is a bug to calculate length of pg_wchar in `gpvars_check_gp_resource_group_cgroup_parent` function. For example, the value "greenplum database" was originally supposed to be judged as an illegal name, and report error: "gp_resource_group_cgroup_parent can only contains alphabet, number and non-leading . _ -". But it was wrongly judged as legal.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi, @fairyfar welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
Contributor
|
The same issue is in archived gp7 repo. It looks like we always copy first 4 bytes of data, which could leads not only to wrong name but also to buffer overflow in a case of empty string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regex matching bug of the GUC gp_resource_group_cgroup_parent
What does this PR do?
This is a code defect of a original GPDB on resource group enabled.
There is a bug to calculate length of pg_wchar in
gpvars_check_gp_resource_group_cgroup_parentfunction.For example, the value "greenplum database" was originally supposed to be judged as an illegal name, and report error:
"gp_resource_group_cgroup_parent can only contains alphabet, number and non-leading . _ -".
But it was wrongly judged as legal.
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions