NODEJS-680: Update and Automate TypeScript Support - 1. config and auth#431
Closed
SiyaoIsTraveling wants to merge 5 commits intoapache:typescriptfrom
Closed
NODEJS-680: Update and Automate TypeScript Support - 1. config and auth#431SiyaoIsTraveling wants to merge 5 commits intoapache:typescriptfrom
SiyaoIsTraveling wants to merge 5 commits intoapache:typescriptfrom
Conversation
Contributor
|
Closing because we want to migrate to TypeScript entirely: #435 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created
tsconfig.jsonso that If you runtsccommand, it will generate type declaration files.d.tsand source map files.d.ts.mapin the folderdist/lib/. Therefore, ourpackage.jsonneeds to pointmaintolib/index.jsandtypestodist/lib/index.d.ts.I also transformed the files in
authfolder to clear most of the typescript errors. It mostly involves refactoring es5 classes to es6 classes.I tested this config with GitHub private npm registry. I published the package privately and tested with a typescript client project. I confirm the type hints and IDE support is working fine for me.
To consider in the future: