This repository was archived by the owner on May 12, 2021. It is now read-only.
Upgrading dependencies to mitigate vulnerabilities#88
Draft
ridv wants to merge 9 commits intoapache:masterfrom
Draft
Upgrading dependencies to mitigate vulnerabilities#88ridv wants to merge 9 commits intoapache:masterfrom
ridv wants to merge 9 commits intoapache:masterfrom
Conversation
StephanErb
reviewed
Oct 13, 2019
Member
StephanErb
left a comment
StephanErb
left a comment
There was a problem hiding this comment.
Thanks a lot for looking into this.
To make a deployment smooth it might make sense though to break this up a bit. Bisecting problems will be difficult if dependency updates are all on one big commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A bot recently reported a large number of vulnerabilities that we inherited from our dependencies.
Creating a draft PR while I verify that these dependency upgrades do not have a negative impact.
Components upgraded:
Testing Done:
TODO
We should run a few end to end test runs to confirm everything is good.
After we merge this PR we need to create a PR for packaging which upgrades the gradle version there.