ATLAS-5204: fix flaky test InMemoryAuditRepositoryTest.testDeleteEventsV2()

[mneethiraj]

What changes were proposed in this pull request?

• added safer time offset to ensure TTL based deletes pick all appropriate events, resulting in consistent test run

How was this patch tested?

• verified the fix by running the test multiple time in an environment where it used to fail few time

[Copilot]

Pull request overview

Stabilizes testDeleteEventsV2() by adding a safety time buffer around the TTL cutoff to avoid boundary-condition flakes in TTL-based deletions.

Changes:

• Capture a single now timestamp and use it consistently within the test.
• Subtract an additional buffer (5 minutes) from the computed “old event” timestamp to ensure events fall clearly outside TTL.
• Reuse now for the “latest” event timestamp instead of calling System.currentTimeMillis() again.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The 5 * DateUtils.MILLIS_PER_MINUTE is a magic number in the test. Consider extracting it into a clearly named constant (e.g., TTL_DELETE_BUFFER_MS) and/or adding a brief reason that’s more specific (e.g., handling timestamp rounding/truncation or cutoff equality) so future readers know why “5 minutes” is required.

[Copilot]

The inline comment is a bit unclear/grammatically awkward (“in env with faster/lightly-loaded env”). Consider rephrasing to something like: “Buffer to avoid TTL cutoff edge cases due to time truncation/rounding or timing granularity across environments.”

Suggested change

	long bufferMs = 5 * DateUtils.MILLIS_PER_MINUTE; // buffer to avoid failure in TTL based delete in env with faster/lightly-loaded env
	long bufferMs = 5 * DateUtils.MILLIS_PER_MINUTE; // buffer to avoid TTL cutoff edge cases due to time truncation/rounding or timing granularity across environments