Landing Page: Card implemented#176
Open
smashbrick wants to merge 1 commit intofear/hov-107-landing-page-navbarfrom
Open
Landing Page: Card implemented#176smashbrick wants to merge 1 commit intofear/hov-107-landing-page-navbarfrom
smashbrick wants to merge 1 commit intofear/hov-107-landing-page-navbarfrom
Conversation
|
SonarCloud Quality Gate failed.
|
pruthvi2103
suggested changes
Mar 16, 2023
Contributor
pruthvi2103
left a comment
pruthvi2103
left a comment
There was a problem hiding this comment.
added comments, pls check
Comment on lines
+9
to
+30
| const CardData = [ | ||
| { | ||
| icon: <EasyToUse />, | ||
| title: "Easy To Use", | ||
| data: "Hover focuses on easy to use betteries included method, so use it as you would use a native element, no need to learn fancy complex apis to do simple things" | ||
| }, | ||
| { | ||
| icon: <FocusOnWhatMatters />, | ||
| title: "Focus On What Matters", | ||
| data: "Easily extend the components and use it to conform to your brand identity." | ||
| }, | ||
| { | ||
| icon: <PlatformAgnostic />, | ||
| title: "Platform agnostic", | ||
| data: "Hover focuses on easy to use betteries included method, so use it as you would use a native element, no need to learn fancy complex apis to do simple things" | ||
| }, | ||
| { | ||
| icon: <Themeing />, | ||
| title: "Themeing", | ||
| data: "Hover focuses on easy to use betteries included method, so use it as you would use a native element, no need to learn fancy complex apis to do simple things" | ||
| } | ||
| ]; |
Contributor
There was a problem hiding this comment.
seperate this into a seperate cardDetails.data.ts file
Comment on lines
+32
to
+42
| const CardDetails = (props) => { | ||
| return ( | ||
| <Card variant="outline" margin="small" className={cardBox}> | ||
| <h3 className={cardTitle}> | ||
| {props.icon} | ||
| {props.title} | ||
| </h3> | ||
| <p>{props.details}</p> | ||
| </Card> | ||
| ); | ||
| }; |
Contributor
There was a problem hiding this comment.
keep components in seperate files
Comment on lines
+48
to
+52
| <CardDetails | ||
| title={object.title} | ||
| details={object.data} | ||
| icon={object.icon} | ||
| /> |
|
|
||
| export const cardBox = style({ | ||
| width: "300px", | ||
| height: "209px", |
Contributor
There was a problem hiding this comment.
no need of height and width here, let content dictate the height and width
| import React from "react"; | ||
| import { HoverProvider } from "@hover-design/react"; | ||
| import { theme } from "../styles/theme/theme"; | ||
| import { Card, Flex } from "@hover-design/react"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented Cards on the landing page
Motivation and Context
Issue : https://linear.app/antstack/issue/HOV-79/landing-page-design#comment-897059bd
Types of changes
Checklist:
Image with temporary background to show text and blur effect
How it looks without the temporary background