Open
Conversation
❌ Deploy Preview for hover-design failed.
|
pruthvi2103
suggested changes
Jan 4, 2023
Comment on lines
5
to
65
| export const [defaultButtonTheme, defaultButtonVars]: ButtonTheme = createTheme( | ||
| { | ||
| color: "#FFFFFF", | ||
| backgroundColor: "#1AB5EB", | ||
| borderColor: "none", | ||
| hoverBackgroundColor: "#008FCB", | ||
| hoverColor: "#FFFFFF", | ||
| hoverBorderColor: "none", | ||
| focusBackgroundColor: "#1AB5EB40", | ||
| focusColor: "#FFFFFF", | ||
| focusBorderColor: "#C6EDFB", | ||
| disabledBackgroundColor: "#8CDAF5", | ||
| disabledColor: "#FFFFFF", | ||
| disabledBorderColor: "none", | ||
| } | ||
| ); | ||
|
|
||
| export const [lightButtonTheme, lightButtonVars]: ButtonTheme = createTheme({ | ||
| color: "#1AB5EB", | ||
| backgroundColor: "#F9F9F9", | ||
| borderColor: "#DDDDDD", | ||
| hoverBackgroundColor: "#F0F0F0", | ||
| hoverColor: "#008FCB", | ||
| hoverBorderColor: "none", | ||
| focusBackgroundColor: "#F9F9F9", | ||
| focusColor: "#1AB5EB", | ||
| focusBorderColor: "#C6EDFB", | ||
| disabledBackgroundColor: "#F9F9F9", | ||
| disabledColor: "#1AB5EB", | ||
| disabledBorderColor: "#DDDDDD", | ||
| }); | ||
|
|
||
| export const [ghostButtonTheme, ghostButtonVars]: ButtonTheme = createTheme({ | ||
| color: "#1AB5EB", | ||
| backgroundColor: "none", | ||
| borderColor: "none", | ||
| hoverBackgroundColor: "#0000000D", | ||
| hoverColor: "#008FCB", | ||
| hoverBorderColor: "none", | ||
| focusBackgroundColor: "none", | ||
| focusColor: "#1AB5EB", | ||
| focusBorderColor: "#C6EDFB", | ||
| disabledBackgroundColor: "none", | ||
| disabledColor: "#1AB5EB", | ||
| disabledBorderColor: "", | ||
| }); | ||
|
|
||
| export const [hallowButtonTheme, hallowButtonVars]: ButtonTheme = createTheme({ | ||
| color: "#1AB5EB", | ||
| backgroundColor: "none", | ||
| borderColor: "#1AB5EB", | ||
| hoverBackgroundColor: "none", | ||
| hoverColor: "#1AB5EB", | ||
| hoverBorderColor: "#AAAAAA", | ||
| focusBackgroundColor: "none", | ||
| focusColor: "#101010", | ||
| focusBorderColor: "#C6EDFB", | ||
| disabledBackgroundColor: "none", | ||
| disabledColor: "#878787", | ||
| disabledBorderColor: "#EEEEEE", | ||
| }); |
Contributor
There was a problem hiding this comment.
- Move the colors to a constants file. we have the styles folder, just make a colors.ts and store colors there
- these themes should be used globally not only for button, define this in
theme/index.ts
|
Kudos, SonarCloud Quality Gate passed!
|
pruthvi2103
approved these changes
Feb 1, 2023
Contributor
pruthvi2103
left a comment
pruthvi2103
left a comment
There was a problem hiding this comment.
LGTM thanks! will merge after i finalize the tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.