docs(forms-guide): explain heroForm reference better#3082
docs(forms-guide): explain heroForm reference better#3082UnnDunn wants to merge 1 commit intoangular:masterfrom
Conversation
The current forms guide uses the heroForm variable without creating or explaining it first, which could cause confusion. This change modifies that section to add the explanation before the variable is used,
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
I added my Git email address to my Google account. Is there a way to get Googlebot to re-check the CLA status? Edit: Well OK then. :) |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
The current forms guide uses the heroForm template reference variable without creating or explaining it first (see the last example in the "Add a Hero and Reset the Form" section). This could cause confusion and presents errors if someone is following along on their machine.
This change modifies that section to add the explanation before the variable is used.