This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Additions to enable navigation highlighting#163
Open
gobijan wants to merge 1 commit intoangular:masterfrom
Open
Additions to enable navigation highlighting#163gobijan wants to merge 1 commit intoangular:masterfrom
gobijan wants to merge 1 commit intoangular:masterfrom
Conversation
===========================
- Added AppCtrl to <html> tag.
- Added AppCtrl to controllers.js.
- Defined $scope.isActive function that takes a viewLocation and returns a boolean if it is the same as $location.path().
- Added ng-class="{ active: isActive('/viewname')}" to ul.menu > li items.
- Added css class .menu > li.active to highlight active navigation item with bold font.
I hope this commit will be accepted as it is a natural feature extension that almost everyone wants to use. If a router is demonstrated with navigation and partials highlighting the current active navigation item makes totally sense to me.
Cheers Bijan
Contributor
|
Hi @tschundeee - thanks for this PR. The trouble is that there are quite a few ways of doing this sort of thing and angular-seed should be agnostic to this and also as simple as possible. I am not sure we should start adding features like this. |
Author
|
Hi Pete, Cheers Bijan |
|
Seeing usage of $location and insitu views would be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions to enable navigation highlighting
I hope this commit will be accepted as it is a natural feature extension that almost everyone wants to use. If a router is demonstrated with navigation and partials highlighting the current active navigation item makes totally sense to me.
Cheers Bijan