Fix reactive forms, debounce inputs#48
Open
actra-gschuster wants to merge 12 commits intoangular-redux:masterfrom
Open
Fix reactive forms, debounce inputs#48actra-gschuster wants to merge 12 commits intoangular-redux:masterfrom
actra-gschuster wants to merge 12 commits intoangular-redux:masterfrom
Conversation
This was referenced Nov 11, 2017
Closed
...to prevent event emission when there in fact is no change. "null" and "undefined" (possibly valid in your state) in fact are empty but unequal to "empty string" (in fact the only valid "empty value" on forms) and thus would trigger "form changed" event.
Only fetch fields as descendants, not FormGroups or FormArrays as otherwise patchValue() runs and endless loop because of strict comparison of old and new value always returning false because FromGroup/FormArray objects fetched from form and store are never the same.
|
This branch will not build for me. connect-array is issuing TS errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes reative forms and adds custom debounce time for form inputs by adding
@Input('debounce')Works as expected with angular 5.1.0-beta.0 and immutable state.