Update dependencies, polish stuff, make FileCallback.onCompleted receive newly created FileCallback.Result and more #144
Closed
w2sv wants to merge 16 commits intoanggrayudi:masterfrom
Closed
Update dependencies, polish stuff, make FileCallback.onCompleted receive newly created FileCallback.Result and more #144w2sv wants to merge 16 commits intoanggrayudi:masterfrom
w2sv wants to merge 16 commits intoanggrayudi:masterfrom
Conversation
…move ExampleUnitTest & fix some gradle deprecation issues
…ntentSender) -> Unit)? = null)
Author
|
Damn, I just now saw #142 😅 |
Owner
|
Hi @w2sv , thanks for raising this PR. I've reviewed your PR and you've done so much to improve the library quality. Unfortunately, I've planned to release v2.0.0 long time ago, and tested it multiple times to ensure its stability. So, I'll merge my PR first, then you can rebase your branch to the latest commits. I'll review your PR again once you've resolved the git conflicts. Thanks in advance. |
Author
|
Yes, sounds absolutely perfect, I'll do that. Great PR btw, the migration to flows is awesome! |
Author
|
Closing as I created an entirely now PR #145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did lots of different things for which I really should have created separate PRs, sorry for that. To break it down:
kotlinsrc dirs and moved thesamplejava files to ajavasrc dirand made it the result type argument of the
FileCallbackclass, to make users unambiguously aware of theonCompletedresult typedata class Report(val progress: Float, val bytesMoved: Long, val writeSpeed: Int)DEPRECATEDsuppressionsto provide a common interface, as well as a higher degree of class cohesion
and made all callbacks holding a CoroutineScope inherit from it. In that wake, I replaced the I believe 103 invocations of
callback.uiScope.postToUiwithcallback.postToUiScopecompileSdkVersionofstorageto 34 and removed the redundanttargetSdkVersion, which has no effect on library modulesAs I said, quite a lot of different things 😄
./gradlew buildpassed without any errors.